-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes Hijack Dropship launch announcement alarm not turning off - Bwoop is Kil #5025
Merged
harryob
merged 20 commits into
cmss13-devs:master
from
hislittlecuzingames:Dropship-Launch-Announcement-Alarm
Nov 26, 2023
Merged
Fixes Hijack Dropship launch announcement alarm not turning off - Bwoop is Kil #5025
harryob
merged 20 commits into
cmss13-devs:master
from
hislittlecuzingames:Dropship-Launch-Announcement-Alarm
Nov 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
…jecting-looping-sounds branch made 5 November 2023 to work)
Thanks to Drulikar for the suggested Documentation. Co-authored-by: Drathek <[email protected]>
…utton is pressed.
Added restriction and warning about playing the alarm when you're not on a landing pad
…om/hislittlecuzingames/cmss13 into Dropship-Launch-Announcement-Alarm
cm13-github
added
the
Merge Conflict
PR can't be merged because it touched too much code
label
Nov 24, 2023
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
Sound
Blast 5 minutes of bass boosted music to our players
UI
deletes nanoui/html
Fix
Fix one bug, make ten more
labels
Nov 24, 2023
hislittlecuzingames
changed the title
Dropship launch announcement alarm
Fixes Hijack Dropship launch announcement alarm not turning off
Nov 24, 2023
…nnouncement-Alarm # Conflicts: # tgui/packages/tgui/interfaces/DropshipFlightControl.tsx
Conflicts have been resolved. A maintainer will review the pull request shortly. |
cm13-github
removed
the
Merge Conflict
PR can't be merged because it touched too much code
label
Nov 24, 2023
removed unnecessary new lines
fira
approved these changes
Nov 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BWOOOOMP is kil
This comment was marked as off-topic.
This comment was marked as off-topic.
Bwoop |
hislittlecuzingames
changed the title
Fixes Hijack Dropship launch announcement alarm not turning off
Fixes Hijack Dropship launch announcement alarm not turning off - Bwoop is Kil
Nov 25, 2023
cm13-github
added a commit
that referenced
this pull request
Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Turns the launch alarm off on dropships when the queen hijacks a ship.
Explain why it's good for the game
Players found the alarm annoying when the ship was hijacked with the alarm sounding and they couldn't turn it off.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty
Queen.Hijack.turns.off.alarm.mp4
Changelog
🆑
fix: Disables launch announcment alarm if it's sounding when queen hijacks
/:cl: