Character creation 'Preferred Armor' preview #5033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plus a bit of a refactor
github-actions
bot
added
Feature
harryob
approved these changes
Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Makes the armour worn by the preview dummy in the character creation menu show the user's 'Preferred Armor' setting.
Also fixes a bug I found where the 'Padded' armour type would have its sprite replaced with the user's preferred style when vended.
This specifically affected the 'Padded' variant because that has the icon states of
L1/1/H1for Light/Medium/Heavy, andpost_vendor_spawn_hook()worked by replacing any1s in theicon_statewith the user's preference.(
post_vendor_spawn_hook()now checks if the armour has style variants before anything else.)Explain why it's good for the game
The 'Preferred Armor' setting can be a bit confusing if you don't actually know what each armour style looks like. (Which I personally didn't until making this PR.)
Testing Photographs and Procedure
Screenshots & Videos
Character creation preview:
preview.mp4
Padded armour bug before: (Preferred Armor set to 'Skull')
bug.before.mp4
Padded armour bug after: (Preferred Armor set to 'Skull')
bug.after.mp4
Changelog
🆑
add: Made the character preview in the character creation menu show the 'Preferred Armor' setting.
fix: Fixed 'Padded' armour being replaced by the user's armour style preference when vended.
/:cl: