Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor got handling infection stage and progess of the black goo disease #5044

Merged
merged 25 commits into from
Dec 16, 2023

Conversation

Huffie56
Copy link
Contributor

@Huffie56 Huffie56 commented Nov 26, 2023

About the pull request

1- reduce the number of stages from 5 to 3. each stage take 6 min or 360s

2-rework the logic that handle the disease progress

A-Set stage_prob to zero to prevent random stage increase.

B-add a stage_level variable that when is at-least 360 make an increase of the disease stage...

C-add an infection_rate variable that handle how fast the stage_level increase passively.
( stage_level = stage_level +infection_rate )
i also made it so that infection-rate is quadruple when the host is dead.

D-I also added that the goo messages (you feel warm ....) give a boost to stage_level to add some randomness to the infection progress.

To do list:
i need to figure out how to increase stage level when someone get hit by a zombie after he is infected...
no idea if i can manage that so i am just going to put what i made up for review...

Explain why it's good for the game

those change are to make infection evolution less random and way more smooth progress with the addition of some random boost with the good message since it's something that could represent a natural boost of the infection progress in the host.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
balance: reduce the number of stages from 5 to 3. each stage take 6 min or 360s.
balance: rework the logic that handle the disease progress
balance: A-Set stage_prob to zero to prevent random stage increase.
balance: B-add a stage_level variable that when is at-least 360 make an increase of the disease stage...
balance: C-add an infection_rate variable that handle how fast the stage_level increase passively.
balance: D-infection_rate is quadruple when the host is dead.
balance: E-I also added that the goo messages (you feel warm ....) give a boost to stage_level to add some randomness to the infection progress.
/:cl:

Julien added 8 commits November 26, 2023 17:11
of the 	"survive_mob_death = TRUE"
also remove the change of desc of the variable
no point setting it twice to null same for curable
commented out codes....
@github-actions github-actions bot added the Refactor Make the code harder to read label Nov 26, 2023
@BeagleGaming1
Copy link
Contributor

BeagleGaming1 commented Nov 26, 2023

How is this a refactor? It is just changing how the disease works

@Huffie56
Copy link
Contributor Author

Huffie56 commented Nov 26, 2023

How is this a refactor? It is just changing how the disease works

what would be the good label for change log then? just code?
i just kinda start doing change to refactor and it got bigger and bigger...

@BeagleGaming1 BeagleGaming1 added Feature Feature coder badge Balance You need to be a professional veteran game maintainer to comprehend what is being done here. and removed Refactor Make the code harder to read labels Nov 26, 2023
@Huffie56 Huffie56 marked this pull request as ready for review November 28, 2023 12:14
make dead host turn faster.
code/datums/diseases/black_goo.dm Outdated Show resolved Hide resolved
code/datums/diseases/black_goo.dm Outdated Show resolved Hide resolved
code/datums/diseases/black_goo.dm Outdated Show resolved Hide resolved
code/datums/diseases/black_goo.dm Outdated Show resolved Hide resolved
code/datums/diseases/black_goo.dm Outdated Show resolved Hide resolved
code/datums/diseases/black_goo.dm Outdated Show resolved Hide resolved
code/datums/diseases/black_goo.dm Outdated Show resolved Hide resolved
code/datums/diseases/black_goo.dm Outdated Show resolved Hide resolved
code/datums/diseases/black_goo.dm Outdated Show resolved Hide resolved
code/datums/diseases/black_goo.dm Outdated Show resolved Hide resolved
Julien added 5 commits December 3, 2023 10:17
into a proper typecheck:
iszombie(H)
also removed zombie_transforming == TRUE
that was with it.
also some minor clean up of code
code/datums/diseases/black_goo.dm Outdated Show resolved Hide resolved
code/datums/diseases/black_goo.dm Outdated Show resolved Hide resolved
code/datums/diseases/black_goo.dm Outdated Show resolved Hide resolved
code/datums/diseases/black_goo.dm Outdated Show resolved Hide resolved
code/datums/diseases/black_goo.dm Outdated Show resolved Hide resolved
Julien added 6 commits December 7, 2023 12:10
made 360 a variable
turn comment into doc format
stage ++ to stage++
impactfulll since they are rarer...
Julien and others added 4 commits December 7, 2023 13:32
remove some empty because harry probably made a block for empty
add return because someone hate empty block
macro time is a thing apparently
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Dec 15, 2023
@Zonespace27 Zonespace27 removed the Stale beg a maintainer to review your PR label Dec 16, 2023
code/datums/diseases/black_goo.dm Outdated Show resolved Hide resolved
@Zonespace27 Zonespace27 added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Dec 16, 2023
@Zonespace27 Zonespace27 added this pull request to the merge queue Dec 16, 2023
Merged via the queue into cmss13-devs:master with commit 0db0ae0 Dec 16, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Dec 16, 2023
@Huffie56 Huffie56 deleted the refactor_blackgoo branch December 17, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants