Prayer and USCM message visibility tweaks #5046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fira
requested changes
Nov 27, 2023
Co-authored-by: fira <[email protected]>
Co-authored-by: fira <[email protected]>
Co-authored-by: fira <[email protected]>
I could have sworn I did it like that :U, fixed |
fira
approved these changes
Nov 27, 2023
|
Whoops, stupid refresh lol. |
fira
reviewed
Dec 1, 2023
| log_admin(msg) | ||
| for(var/client/C in GLOB.admins) | ||
| if(AHOLD_IS_MOD(C.admin_holder) && C.prefs.toggles_chat & CHAT_PRAYER) | ||
| to_chat(C, msg) | ||
| C << 'sound/machines/terminal_alert.ogg' |
There was a problem hiding this comment.
does that work without the sound() ?
There was a problem hiding this comment.
Yes, it does. The USCM message does the same thing below and it also plays the sound.
Or well at least did when I tested it the few days ago before putting it up, I dont think anything has changed in how sounds are handled. I def tested, multiple times, because I wanted to be sure the sound isn't too jarring or annoying to prevent it being ignored or muted ;P
realforest2001
approved these changes
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR adds one of the distinct, but hopefully not disruptive terminal sounds to the message prompt mods/admins relieve when a player sends a prayer and makes both the USCM emergency message prompts and prayer prompts one size up from current font size and bolded for better visibility.
Something something downstream improvement that really should be upstream something.
Explain why it's good for the game
Prayer visibility in particular has always been an issue, now not only there is a sound, these messages are bolded and slightly bigger.
Testing Photographs and Procedure
Screenshots & Videos
My font settings:
The messages, surrounding a regular prompt:
The sound is sound\machines\terminal_alert.ogg
Changelog
🆑silencer_pl
admin: Recieving prayers now makes a sound
admin: Prayers and USCM emergency messages are now better highlighted for mods/admins
/:cl: