Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standartize squad vendors items prices #5047

Conversation

Huffie56
Copy link
Contributor

@Huffie56 Huffie56 commented Nov 27, 2023

About the pull request

1-standartize cost of M3 and M4 armor to 30 each

2-moving NVG to helmet optic section for TL

3-standartize availability for all binoculars and their cost bino cost 5 range finder cost 10 laser designator

4-standartize availability for VP78 pistol and SU-6 first will cost 10 second will cost 15

Explain why it's good for the game

1,3,4:
it's smooth out differences of price between objects when their is no reason for it/
example being M3 armor and SU-6 or VP78 being cheaper for medic than it is for TL

3:is also because i think most people should have access to all the binoculars...

2:
it's just a qol i forgot to do in the last PR...

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
qol: moving NVG to helmet optic section for TL
balance: standartize cost of M3 and M4 armor to 30 each
balance: standartize availability for all binoculars and their cost bino cost 5 range finder cost 10 laser designator
balance: standartize availability for VP78 pistol and SU-6 first will cost 10 second will cost 15
/:cl:

@github-actions github-actions bot added Quality of Life Make the game harder to play Balance You need to be a professional veteran game maintainer to comprehend what is being done here. labels Nov 27, 2023
@Huffie56 Huffie56 marked this pull request as ready for review November 27, 2023 13:27
@Zonespace27
Copy link
Contributor

Explain why this is good for the game

@Zonespace27 Zonespace27 added the Do Not Merge If you merge this PR, I will annihilate you label Nov 27, 2023
@Huffie56
Copy link
Contributor Author

Explain why this is good for the game

sorry forgot to fill the section for it...
1,3,4:
it's smooth out differences of price between objects when their is no reason for it/
example being M3 armor and SU-6 or VP78 being cheaper for medic than it is for TL
3:is also because i think most people should have access to all the binoculars...
i am not againt's difference in prices for items but i don't see a reason for those items to be cheaper for those jobs.

@Huffie56
Copy link
Contributor Author

i could understand not wanted prices change but can i atleast keep the addition of the availability of all bino for most squad marine roles?

@Zonespace27 Zonespace27 removed the Do Not Merge If you merge this PR, I will annihilate you label Nov 28, 2023
Copy link
Contributor

@Birdtalon Birdtalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple changes. Would just need balance approval.

@Huffie56
Copy link
Contributor Author

Huffie56 commented Dec 1, 2023

closing this PR because i want to tottaly change it's aim and scope...

@Huffie56 Huffie56 closed this Dec 1, 2023
@Huffie56 Huffie56 deleted the standartize_squad_vendor_itemsprices branch December 3, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Quality of Life Make the game harder to play
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants