Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes flame particles #5055

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Conversation

morrowwolf
Copy link
Member

@morrowwolf morrowwolf commented Nov 28, 2023

About the pull request

This is a paid PR.

Allegedly fire was lagging the player. I assume the particles are the issue.

Explain why it's good for the game

Given the vast range of people who play CM with varying levels of computer hardware it would be prudent to remove anything that may be lagging players. Game feel good.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 Morrow
del: Removed flame particles. Possibly increases performance for some players.
/:cl:

@github-actions github-actions bot added the Removal snap label Nov 28, 2023
@SabreML
Copy link
Member

SabreML commented Nov 28, 2023

If the particles only affect a small number of players, would it be worth putting them behind a 'Fancy Graphics' preference or something similar? That would solve the issue, and also allow other similar effects to be added to it in the future.

@fira
Copy link
Member

fira commented Nov 28, 2023

I wish but I don't think you can easily put them behind a toggle short of maybe rendering doubled to a second optional plane ? That's going to be a lot of logistics for just that

Would normally be against such PRs but the effect is pretty subtle to begin with

@ihatethisengine
Copy link
Contributor

I can confirm fire lags a lot

@morrowwolf
Copy link
Member Author

Honestly it still looks fine without it, the effect here is sorta minimal.

I think you can add particles to client images but it'd be kinda weird iunno.

@Nanu308 Nanu308 added the Sprites Remove the soul from the game. label Nov 29, 2023
@Nanu308
Copy link
Member

Nanu308 commented Nov 29, 2023

Gonen throw on the sprite label for le spriters to judge the funny visual looks

@harryob harryob added this pull request to the merge queue Nov 30, 2023
@harryob
Copy link
Member

harryob commented Nov 30, 2023

lummox keeps saying he'll make particles perform better eventually. maybe one day

Merged via the queue into cmss13-devs:master with commit 858b1f3 Nov 30, 2023
28 checks passed
cm13-github added a commit that referenced this pull request Nov 30, 2023
@morrowwolf morrowwolf deleted the flamer-particles branch November 30, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Removal snap Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants