Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes whiskey outpost rarer + adds pop lock #5062

Merged
merged 9 commits into from
Dec 3, 2023

Conversation

ihatethisengine
Copy link
Contributor

@ihatethisengine ihatethisengine commented Nov 29, 2023

About the pull request

Whiskey outpost is available 3 times less often + requires 140 players to be online.

Explain why it's good for the game

The gamemode get into the vote way more often than once per 5 day, plus for some reason can be rolled during lowpop hours (and this gamemode is awful on lowpop).

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 ihatethisengine
add: Whiskey outpost is voteable less often and requires 140 players.
/:cl:

@github-actions github-actions bot added the Removal snap label Nov 29, 2023
@hislittlecuzingames

This comment was marked as off-topic.

@BadAtThisGame302
Copy link
Contributor

Whiskey Outpost is one of the things keeping CM from being stale and it's a change of pace which I personally think is good if it was changed a bit perhaps it'd be perfect.

@ihatethisengine
Copy link
Contributor Author

Whiskey Outpost is one of the things keeping CM from being stale and it's a change of pace which I personally think is good if it was changed a bit perhaps it'd be perfect.

If I want change of pace I play another game, if I want to play CM I don't want to play Whiskey Outpost

Copy link
Member

@fira fira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not a removal that's disabling

@ihatethisengine
Copy link
Contributor Author

That's not a removal that's disabling

what tag should I use? Fix? Add? Qol?

@ihatethisengine ihatethisengine changed the title Removes whiskey outpost Disables whiskey outpost Nov 29, 2023
@Googles-Hands
Copy link
Contributor

If I want change of pace I play another game, if I want to play CM I don't want to play Whiskey Outpost

Whiskey Outpost is capped at one hour. Go touch some grass, maybe cook a healthy meal if you truly cannot bear spending one hour not playing CM.
Relatedly "Why it's good for the game" has not been properly explained.

@ihatethisengine
Copy link
Contributor Author

Whiskey Outpost is capped at one hour. Go touch some grass, maybe cook a healthy meal if you truly cannot bear spending one hour not playing CM.

Ok bro go watch the paint dry if you enjoy WO, you'll get roughly the same experience. Some people cannot play the game all day just to wait for next round, and even if they can, why would they NOT play CM if they want play CM?

Relatedly "Why it's good for the game" has not been properly explained.

There is nothing left to explain, everyone knows about tons of issues WO has and about the lack of anyone interested in coding for WO.

@Googles-Hands
Copy link
Contributor

Googles-Hands commented Nov 29, 2023

Ok bro go watch the paint dry if you enjoy WO, you'll get roughly the same experience. Some people cannot play the game all day just to wait for next round, and even if they can, why would they NOT play CM if they want play CM?

The fact that people vote for it, shows that a majority of people on the server DO want to play it. If it were that hated, it would never be played, so as it stands it would be like removing Soro because "it's bad, many don't like it and it gets voted once a day at max".

There is nothing left to explain, everyone knows about tons of issues WO has and about the lack of anyone interested in coding for WO.

That would be a fair point, but as of right now, there is one issue open concerning Whiskey Outpost, if the balance complaints and issue reports were to be of a massive amount I could see how arguing for it's removal would be sensible.
But if the major complaint is that it's just a massive FOB defence, then that is intended and not something to complain about/remove it over.

@Nanu308 Nanu308 added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Nov 29, 2023
@Nanu308
Copy link
Member

Nanu308 commented Nov 29, 2023

I think the one of the main issues is that WO can be voted on lowpop, it should be population locked as well as only be every X rounds to not become stale.

I don't necessarily think removing WO is the best choice, I'd rather try the above or other changes.

Besides that, just the "Please" is not a fulfilling reasoning for removing an entire gamemode. Fill that out and give reasoning, until then I'm putting the DNM label on.

@Nanu308 Nanu308 added the Do Not Merge If you merge this PR, I will annihilate you label Nov 29, 2023
@ihatethisengine
Copy link
Contributor Author

Done

@Googles-Hands
Copy link
Contributor

Googles-Hands commented Nov 29, 2023

I think the one of the main issues is that WO can be voted on lowpop, it should be population locked as well as only be every X rounds to not become stale.

I brought this up before on the discord. I'm gonna repeat it here incase anyone intends to add the highpop requirement and wants some history to help.
So:

In the past Whiskey Outpost, like all other big maps, had a population limit of 130 to be voted on, back when CM was still on gitlab Geeves changed (https://gitlab.com/cmdevs/colonial-warfare/-/merge_requests/2771) how the Whiskey Outpost vote worked.
He changed it from just being a mapvote to the current gamemode vote first, then just a map vote with the single map. He explicitely removed the minimum population limit and stated this in his MR, this was approved by you Nanu, I haven't found any real justification for the removal of the pop-limit alongside the vote change, it's probably somewhere in the discord.

Since I found this strange and 80 player WO was/is bad, I asked around the discord and got approval to re-add the 130 limit. (https://discord.com/channels/150315577943130112/745447048261795890/1044613870070804500)
But I then found out I can't just add the one-line-change pop requirement as it was, since that only prevents maps from being voteable, and with Geeves' MR, WO was changed to be voted as a gamemode first, meaning a 130 limit would only prevent a map from being voted on after WO was already selected as the next rounds gamemode. His gamemode vote couldn't be changed so easily and that was beyond me.
So I asked Geeves if he could try but he said he hadn't looked at the gamemode vote system for a long time. (https://discord.com/channels/150315577943130112/745447048261795890/1045054704369012776)

So Whiskey Outpost has been stuck like this since March of last year, I suppose I have to concede that indeed, no one wants to work on WO.

@Diegoflores31
Copy link
Contributor

So Whiskey Outpost has been stuck like this since March of last year, I suppose I have to concede that indeed, no one wants to work on WO.

whiskey has received some updates thought the year the most recent being one made by Fira like 1 month ago

@ihatethisengine
Copy link
Contributor Author

whiskey has received some updates thought the year the most recent being one made by Fira like 1 month ago

You mean the req update? Then you should also count pred removal, that happened just yesterday. Obviously when we are talking about WO development we mean important gameplay changes, not some minor details.

@Diegoflores31
Copy link
Contributor

You mean the req update? Then you should also count pred removal, that happened just yesterday. Obviously when we are talking about WO development we mean important gameplay changes, not some minor details.

By that logic lets just remove big red and soro because they havent got any major changes in half a year

@Googles-Hands
Copy link
Contributor

whiskey has received some updates thought the year the most recent being one made by Fira like 1 month ago

I was talking about it being stuck without a pop limit.

@Diegoflores31
Copy link
Contributor

whiskey has received some updates thought the year the most recent being one made by Fira like 1 month ago

I was talking about it being stuck without a pop limit.

I guess lowpop players want WO too 😈

@ihatethisengine
Copy link
Contributor Author

ihatethisengine commented Nov 30, 2023

By that logic lets just remove big red and soro because they havent got any major changes in half a year

Logic is not your strong side. Big red doesn't have the same amount of problems as WO, Soro is not the best map surely, but still it is at least not a cadehug/suicide simulator either. Why would you compare incomparable?

Not to mention WO is a gamemode, and Distress Signal gets updated constantly.

@ihatethisengine
Copy link
Contributor Author

I guess lowpop players want WO too 😈

Yeah, vote WO and go to sleep, while the rest of the players suffer. I honestly don't understand this appeal to majority. During the last public vote about WO iirc the vote was pretty close, even though WO lovers won. But it's been months, and the gamemode got even more stale. I personally voted against removal, but now I learned to hate WO.

But even if we still have like 51% of people who are fine with WO, I think like 30% of people who hate WO with passion is a good enough reason for removal.

I don't think I ever seen WO winning by more than 10 votes, most of the times it's a very close win, with 1-3 votes difference. So you can imagine how many people really don't want WO.

@Steelpoint
Copy link
Contributor

Sometimes you may only have enough time to commit to one round or even half of one round a day, depending on real life issues. Logging on to find the game is set to Whisky Outpost is disheartening. WO is not CM.

Furthermore, I genuinely think that Whisky Outpost is borderline insulting to xenomorph players. These players are being expected to spawn in as literal canon fodder and are told to rush and die to the Marines for an hour.

If an admin made a event where half the server were spawned in as Lesser Drones and were made to charge at a marine and die over and over, it'd be called a bad event. But make it a game mode and its perfectly fine.

I support removing or disabling it.

@fira
Copy link
Member

fira commented Dec 1, 2023

This Convo is unreadable, please use PR Feedback on forums 😭

@ihatethisengine
Copy link
Contributor Author

We need to move back to gitlab

Copy link
Contributor

@Zonespace27 Zonespace27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seconding @Nanu308 's first two points.

@ihatethisengine ihatethisengine marked this pull request as draft December 2, 2023 04:41
@ihatethisengine
Copy link
Contributor Author

alright Ill make it more rare and figure pop lock

@ihatethisengine ihatethisengine changed the title Disables whiskey outpost Makes whiskey outpost + adds pop lock Dec 2, 2023
@ihatethisengine ihatethisengine marked this pull request as ready for review December 2, 2023 05:14
@ihatethisengine ihatethisengine changed the title Makes whiskey outpost + adds pop lock Makes whiskey outpost rarer + adds pop lock Dec 2, 2023
@Zonespace27 Zonespace27 added Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. and removed Do Not Merge If you merge this PR, I will annihilate you labels Dec 3, 2023
@Zonespace27 Zonespace27 added this pull request to the merge queue Dec 3, 2023
Merged via the queue into cmss13-devs:master with commit 732f2e9 Dec 3, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Removal snap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants