Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CL Briefcase Radio Keys #5063

Merged
merged 10 commits into from
Dec 15, 2023
Merged

Conversation

blackdragonTOW
Copy link
Contributor

@blackdragonTOW blackdragonTOW commented Nov 29, 2023

About the pull request

CLs lost squad comms a while back and this has hampered some RP in select cases. This re-adds them but at a cost. Given that were pulling them from the briefcase, this gives the CL's case more value and more things to spend points on rather than the usual gimmicks.

Squad key costs = 25 each (if they want all 4 squads, they need 100 points)
Wey-Yu related groups = 30 each
Contraband groups = 50 each (note: this is 100% of the CLs max points) this is mostly to create RP as the CL can get caught with these keys.

Willing to have a conversation about key costs (CLs start with 50 (cap is 50) and generate 1 per minute, meaning for 100 points they need to dump all starting points and play for 50min.)

Explain why it's good for the game

CL Briefcase's typically are meme spawns, this will allow for more interesting choices.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Added Radio Keys to the CL's briefcase
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Nov 29, 2023
After some brief conversations with people made the following changes:
-Across the board reduction by 10 points
-Color field wasn't working, so reverted to White
-Moved the Contraband warning tag from the info desc to the name of the item to make it obvious to the CL
@blackdragonTOW
Copy link
Contributor Author

After some brief conversations with people made the following changes:
-Across the board reduction by 10 points
-Color field wasn't working, so reverted to White
-Moved the Contraband warning tag from the info desc to the name of the item to make it obvious to the CL

@realforest2001 realforest2001 marked this pull request as draft November 30, 2023 21:28
@Drulikar
Copy link
Contributor

Drulikar commented Dec 2, 2023

Mentioned this on discord, but to do what you were trying to do earlier with contraband, I'd recommend a separate list that your var can optionally display in addition the regular items. A way to do this would be like this:
patch.diff.txt

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Dec 10, 2023
draks changes of making a new optional catagory
@blackdragonTOW blackdragonTOW marked this pull request as ready for review December 15, 2023 18:43
@Drulikar Drulikar added this pull request to the merge queue Dec 15, 2023
Merged via the queue into cmss13-devs:master with commit 7698aeb Dec 15, 2023
27 checks passed
cm13-github added a commit that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants