Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gau rework this time for real ;) #5068

Closed

Conversation

cuberound
Copy link
Contributor

@cuberound cuberound commented Nov 29, 2023

About the pull request

removes the whole bullet thing from the the GAU.
Makes all the shots impact at the same time.
Reduces spread to 3 from 4 (hits 49 instead of 81).
Reduces FM delay to 1. (means you can fire each tile in FM, quite easy to set up with new UI, thanks for that)
Ammo 400->600 (to keep the same fm lenght with the new FM delay)
Uses 30 shots per burst
Makes each bullet impact unique tile, just like laser to prevent some rng instagibs (do not want the chance that someone gets impacted by 10 gau bullets from single burst and stops existing, however unlikly it is.)
Adds max holo effect to each bullet.
Adds 10 toxic to each bullet that maxcaps at 1/5 of enemy armor
Adds 3 sec superslow to impacted mob
Reduces traveling time of the ammo to 2 sec
Gives hit xenos interference effect that maxes out at 10
Gives hit xenos healing_reduction, no maxcap, was told it is shit anyway

Explain why it's good for the game

GAU needs rework. A lot. I am trying to place it into suppressive role with this PR as it mini stuns and mini slows enemies hit and aplies holo effect (before you get mad about that... max holo is like taking 10% of enemy health and it does not stack, so 100 from queen max...). It mainly aims to make it work with other guns with bigger damage, so I might add more negative effects (smoke??) to fit more in the role, as those effects do not stack so if you are being shot at by 1 or 4 gau they will be the same.
This also aims to make GAU usable with new UI that does not support diferent FM lenghts... they exist only for GAU anyway.
Also the reduced travel time combined with the negative effects applied on impacted enemies and lower price per shot might make it useful transport gun.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
balance: GAU ammo aplies 10 toxic up to 1/5 of target armor
balance: GAU spread 4 ->3
balance: GAU FM delay 2->1
balance: GAU ammo 400 -> 600
balance: GAU ammo applies max holo effect
balance: GAU ammo aplies short super slow
balance: GAU ammo damage 105 -> 80
balance: GAU AP ammo removed
balance: GAU explosions removed
balance: GAU gives 10 interference
balance: GAU gives healing_reduction
code: removes shrapnel from GAU

/:cl:

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Nov 29, 2023
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Code Improvement Make the code longer labels Nov 29, 2023
@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Nov 29, 2023
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cuberound cuberound marked this pull request as ready for review November 29, 2023 18:39
@cuberound
Copy link
Contributor Author

do not merge or TM for now, numbers need some changes and testing, too strong for now, looking for more debuffs to replace damage with

@cuberound cuberound marked this pull request as draft November 30, 2023 10:16
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Dec 10, 2023
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Dec 12, 2023
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Stale beg a maintainer to review your PR label Dec 13, 2023
@Zonespace27
Copy link
Contributor

Reopen when you want to work on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Code Improvement Make the code longer Merge Conflict PR can't be merged because it touched too much code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants