Moves lore descriptions into the chat window #5082
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know... Chat isn't the most suitable to reading long blocks of text uninterrupted |
Normally I'd agree, but this is on user click, like the user specifically asks for it. |
|
Having said that this seems like messing around actually making a proper tgui display for this and it feels half assed, soooo I'll go back to the drawing board |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Currently lore descriptions open their own browser window using BYONDs 'magic' method that's essentially what nanoUI does. This MR makes them display underneath regular descriptions (still only on click of the button), using the same styling brackets as regular descriptions do.
Explain why it's good for the game
The end result is way less jarring, does not open an extra window on top of the game and respects tgchat font etc settings.
Testing Photographs and Procedure
Screenshots & Videos
Changelog
🆑silencer_pl
ui: lore descriptions are now sent via examine brackets to the main chat window
/:cl: