Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds returns to prevent runtimes in /datum/component/healing_reduction/process(delta_time) hopefuly #5084

Merged
merged 6 commits into from
Dec 3, 2023

Conversation

cuberound
Copy link
Contributor

@cuberound cuberound commented Nov 30, 2023

About the pull request

when there is no parent the function deleted src but then kept going and asked for parent of null, it calls return now instead

Explain why it's good for the game

runtime bad

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
fix: fixed a runtime in /datum/component/healing_reduction/process(delta_time)
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Nov 30, 2023
@cuberound
Copy link
Contributor Author

cuberound commented Dec 1, 2023

was a bit tired yesterday when I found it, all vars in the file should be renamed

code/datums/components/healing_reduction.dm Outdated Show resolved Hide resolved
code/datums/components/healing_reduction.dm Outdated Show resolved Hide resolved
@cuberound
Copy link
Contributor Author

makes sence, they were not used at all under it so I did not know what to name them. should have kept it simple

@Birdtalon Birdtalon added this pull request to the merge queue Dec 3, 2023
Merged via the queue into cmss13-devs:master with commit 570f55a Dec 3, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants