Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Jungle boots to the surplus vendors #5102

Closed
wants to merge 1 commit into from

Conversation

Googles-Hands
Copy link
Contributor

@Googles-Hands Googles-Hands commented Dec 2, 2023

About the pull request

Adds the Jungle Combat Boots to the marine vendor.

Explain why it's good for the game

This completes #4996 and let's you save even more loadout points to spend on candy.

Testing Photographs and Procedure

CMjungleboots

Changelog

🆑 Googles_Hands
add: Jungle boots are now vendable from the surplus vendors.
/:cl:

Adds the Jungle Combat Boots to the marine vendor
@github-actions github-actions bot added the Feature Feature coder badge label Dec 2, 2023
@Googles-Hands Googles-Hands changed the title welcometothejungle.dm Adds Jungle boots to the surplus vendors Dec 2, 2023
@fira
Copy link
Member

fira commented Dec 2, 2023

Well I don't know... Wouldn't have approved #4996 to begin with if I knew they were in loadouts to begin with...
The more loadout items you make available everywhere else the less of a special thing they become and the more they just become an hinderance for being in loadout system at all

@Googles-Hands
Copy link
Contributor Author

Well I don't know... Wouldn't have approved #4996 to begin with if I knew they were in loadouts to begin with... The more loadout items you make available everywhere else the less of a special thing they become and the more they just become an hinderance for being in loadout system at all

I'm not arguing for things in the vendors to be removed from the loadout system, a lot of roles (survivours, ERT's, anyone who doesn't have access to squad prep) should still be able to get them in their loadout.
But at this point it's just about consistency, a large amount of loadout cosmetics are available from vendors, patches, helmet accessories, other small things like gun oil and stuff like that. Why were they all added if this is an issue for you, or rather, why stop now?
Putting the "standard military" items, like these boots, in the vendor leaves more points for other items from the loadout to be deployed.
Plus, a lot of people do not notice new additions to the loadout stock, honestly I think I've been the only one taking these boots whenever I played LV, putting them in the vendor may make them more commonly used.

@fira
Copy link
Member

fira commented Dec 3, 2023

People having more loadout points to spend is not neccessarily better vs what loadouts are trying to achieve. If it was we'd just increase the points, no need to dump half the codebase in every vendor.

My point is the more things are made readily available the less interesting they are as loadout item, effectively reducing outfiting possibilities since anyone can now take them instead. I think of loadouts not just as drip but as providing objects of interest or with some RP value.

Imagine if we made a plush vendor with all the new plushs. What do you think's gonna happen? Well nobody will have "theirs", instead you'd have 80 random ones scattered everywhere in briefing room.

So yeah i don't have immediate concerns for just this PR, but i don't think this reasoning is one we'd want to follow in the future...

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Dec 11, 2023
@github-actions github-actions bot closed this Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants