Added launch alarm for PR #4976 #5105
Conversation
|
Hi, 4976 author here. I think the automated ship announcement is good in addition to the sound so that you'll know whether the port or starboard boat is the one launching - I assume the sound will go far enough that it isn't obvious which boat it's coming from at first. Also, thank you!! Ever since the dropship alarm got merged, I was thinking of stealing it for my PR and never got around to it, heh. ❤️ (Also adding link to #4976 on comment rather than just on commits for my own sanity) |
|
Are you adding code on top of #4976 here? It took me a while to clock that I'd seen this code in another PR and I didn't realise that's what you meant from the title. I'm adding the DNM tag until #4976 is merged or closed. In future please document this in your PR description as it looks as though you're also changing access & launch options here which isn't documented in your PR, when it's actually #4976 Edit; just read the comment @zzzmike thank you for the information here. @fordmichigan could you please just add a line in your PR description that references this so anyone else that looks at this (who might not have seen #4976 ) can see easily what's going on. |
|
Is it good now? |
👍 thanks. Will wait for #4976 then I will remove DNM |
cm13-github
added
the
Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
cm13-github
removed
the
Merge Conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
About the pull request
Adds a looping alarm sound when the lifeboats are launched. This also uses the function described in PR #4976 to trigger the sound. This is NOT for adding those features, so wait until that is merged to merge this PR.
Explain why it's good for the game
Denies the need to make an announcement warning marines that the lifeboats are leaving.
Testing Photographs and Procedure
Screenshots & Videos
https://youtu.be/L8ia2OKhUUA
Changelog
🆑alexguinea atticus-rezzer
add: Adds alarm sound for lifeboats when launching
/:cl: