-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Componentizes rechargers & unwrenching #5107
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me overall
Co-authored-by: fira <[email protected]>
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
…ss13 into component-charger
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know all the possible things that are in game that might be recharged but I can confirm defibs and smart gun batteries recharge fine. However, it doesn't seem like you can recharge M2 Nightvision goggles using a cell (specifically a /obj/item/cell/hyper
) because that is still accessing the .charge of the cell which in this case is -1 to indicate it should spawn w/ full charge. So there are still lingering references to charge that aren't using the cell component.
I'd recommend deleting that charge var; look at where all the compiler errors, ensure you properly get the charge from the component where needed, then return the var back if its still needed.
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
Will finish eventually |
About the pull request
Converts rechargers into a component.
Also converts the ability to unwrench things into an element due to it being needed to have feature parity w/ recharger componentization.
Marked as draft until I add cell components to everything that can be put into a recharger.
Explain why it's good for the game
I want to be able to add a form of recharger to more things, so componentization is necessary.
🆑
fix: You can no longer unwrench certain atmos parts.
\🆑