Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes disarm chance calculation #5111

Merged
merged 7 commits into from
Dec 6, 2023
Merged

Conversation

zzzmike
Copy link
Contributor

@zzzmike zzzmike commented Dec 3, 2023

About the pull request

I was testing stuff out for a different PR and thought the disarm chance (for human vs human) seemed weird at times, so I forced it to output attacker_skill_level and defender_skill_level to chat every time a disarm was done. And then found out it's not calculating it properly. This seems to fix it in limited testing but might need more testing. I'm kinda surprised it wasn't noticed earlier cause there's two signs it's wrong in certain situations even with skill_level variables being invisible: the "tackled" message should only appear when the attacker's CQC level is two or higher (otherwise it should say pushed/shoved), and also, anyone that has a CQC advantage is still disarm-stunning everyone for the same amount of time as anyone else on average ('on average' because there was apparently some variance with a tick offset bug before the TG status effect testmerge) - the code implies it should be longer.

Explain why it's good for the game

Bugs should be fixed. From a balance perspective I don't know if it 'should' be fixed from what it is currently in it's bugged state... but regardless, it's a bug.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
fix: disarm chance wasn't calculating properly
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Dec 3, 2023
@zzzmike zzzmike marked this pull request as draft December 3, 2023 08:25
@zzzmike zzzmike marked this pull request as ready for review December 3, 2023 08:35
@zzzmike zzzmike requested a review from fira December 3, 2023 15:47
@Drulikar Drulikar marked this pull request as draft December 6, 2023 07:15
@zzzmike zzzmike marked this pull request as ready for review December 6, 2023 11:06
@Drulikar Drulikar added this pull request to the merge queue Dec 6, 2023
Merged via the queue into cmss13-devs:master with commit 01ec6e3 Dec 6, 2023
27 checks passed
@zzzmike zzzmike deleted the patch-2 branch December 6, 2023 12:00
cm13-github added a commit that referenced this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants