Fixes a few lowercase chat messages #5112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Birdtalon
approved these changes
Dec 3, 2023
github-actions
bot
added
the
Grammar and Formatting
Drulikar
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Fixes some chat messages not being properly capitalised.
RegEx used to search:
(?:to_chat|visible_message)[^"]*"[a-z](I just threw the regex together in a couple of minutes, so I've probably still missed a bunch of cases.)
Explain why it's good for the game
Inconsistencies. (And it looks better)
Testing Photographs and Procedure
Screenshots
Before:
After:
(Plus a few others, but these are the most common for players.)
Changelog
🆑
spellcheck: Fixed some chat messages which started with a lowercase character.
/🆑