Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a runtime in spiders.dm attackby() #5114

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

Birdtalon
Copy link
Contributor

@Birdtalon Birdtalon commented Dec 3, 2023

About the pull request

[2023-12-03 16:02:14.678] runtime error: Cannot read null.len
 - proc name: attackby (/obj/effect/spider/attackby)
 -   source file: code/game/objects/effects/spiders.dm,24
 -   usr: Conner Scott (/mob/living/carbon/human)
 -   src: the spiderling (/obj/effect/spider/spiderling/nogrow)
 -   usr.loc: the floor (90,115,2) (/turf/open/floor/prison)
 -   src.loc: the catwalk (89,116,2) (/turf/open/floor/plating/plating_catwalk/prison)
 -   call stack:
 - the spiderling (/obj/effect/spider/spiderling/nogrow): attackby(the box of shotgun slugs (/obj/item/ammo_magazine/shotgun/slugs), Conner Scott (/mob/living/carbon/human), /list (/list))
 - Conner Scott (/mob/living/carbon/human): click adjacent(the spiderling (/obj/effect/spider/spiderling/nogrow), the box of shotgun slugs (/obj/item/ammo_magazine/shotgun/slugs), /list (/list))
 - Conner Scott (/mob/living/carbon/human): do click(the spiderling (/obj/effect/spider/spiderling/nogrow), the catwalk (89,116,2) (/turf/open/floor/plating/plating_catwalk/prison), "icon-x=18;icon-y=15;left=1;but...")
 - ****** (/client): Click(the spiderling (/obj/effect/spider/spiderling/nogrow), the catwalk (89,116,2) (/turf/open/floor/plating/plating_catwalk/prison), "mapwindow.map", "icon-x=18;icon-y=15;left=1;but...")

Explain why it's good for the game

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
fix: Fixes runtime in spiders.dm
/🆑

@Birdtalon Birdtalon changed the title Fixes a runtime in spiders.dm Fixes a runtime in spiders.dm attackby() Dec 3, 2023
@Birdtalon Birdtalon added the Fix Fix one bug, make ten more label Dec 3, 2023
@Drulikar Drulikar added this pull request to the merge queue Dec 5, 2023
Merged via the queue into cmss13-devs:master with commit afec307 Dec 5, 2023
28 checks passed
cm13-github added a commit that referenced this pull request Dec 5, 2023
@Birdtalon Birdtalon deleted the attackbynulllen branch December 21, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants