Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect location name #5123

Closed
wants to merge 1 commit into from
Closed

Conversation

zzzmike
Copy link
Contributor

@zzzmike zzzmike commented Dec 4, 2023

About the pull request

From observing a dead chat death and seeing where the person is - this is not aft, it is fore. I don't know every place that this should be changed but, at least I'll fix the crew monitor and dead chat this way hopefully.

Explain why it's good for the game

bug bad

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
fix: Upper Deck Aft location was wrong, it's actually fore.
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Dec 4, 2023
@zzzmike
Copy link
Contributor Author

zzzmike commented Dec 4, 2023

nevermind, i think the fix is more complex... i think it's detecting aft and fore hallways as aft..

edit: Well there's stern hallway, and aft hallway, but no fore hallway. Might close this depending on feedback if I get any, I don't know, let me know if you have any insights on if the existing code is correct or what it should be.

@zzzmike zzzmike marked this pull request as draft December 4, 2023 20:45
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Dec 12, 2023
@Drulikar
Copy link
Contributor

The areas appear to be correct; if anything it would be a mapping issue not a coding issue. But as is the Aft hallways is more forward than the stern hallways correctly.
image
image
image
image

@Drulikar Drulikar closed this Dec 12, 2023
@Huffie56
Copy link
Contributor

Huffie56 commented Dec 12, 2023

@zzzmike https://discord.com/channels/150315577943130112/964684928161808384/1184050174293725215

if you want i can find you an issue to investigate and or fix
tag me on discord in cm discussion or here if you aren't on discord.

@zzzmike zzzmike deleted the patch-4 branch July 16, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants