Fixes a freeze when opening the 'Create Object' panel #5125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Removes the long freeze when opening the 'Create Object' interface through the game panel.
This was caused by line 40 of
create_object.html
, which attempts to fill the object list with every subtype of/obj
when the interface is first opened. The "fix" was just removing that line.cmss13/html/create_object.html
Lines 33 to 42 in 0b13392
This does mean that the user has to search for a type before anything shows up, but I would consider that a pretty minor trade-off.
I also increased the window size so that the 'Spawn' button is on the screen by default, removed a couple of empty
value
s, and added some spaces so that the HTML code lines up a bit more with the final UI.Explain why it's good for the game
Fixes a 30ish second freeze for admins. (Give or take a bit, but it's still long either way.)
Testing Photographs and Procedure
Videos
Before:
Before.mp4
After:
After.mp4
Changelog
🆑
admin: Fixed a freeze when opening the the 'Create Object' interface.
admin: Adjusted the size and positioning of the 'Create Object/Mob/Turf' panels so that everything fits into the window.
/:cl: