XO can award distinguished conduct medals #5131
Conversation
ihatethisengine
force-pushed
the
xomedal
branch
from
ab0da86
to
9b443d4
Compare
|
DNM pending maintainer discussion. The uniqueness of COs being able to give medals is one of the more prevalent parts of the whitelist and we'll need to talk this over to see how that goes in the grand scheme of things. To be clear, I'm not strictly against it. I just think this needs time in the oven for us to talk over. If it gets approved after the talks, that's fine with me. |
ihatethisengine
changed the title
|
Done |
ihatethisengine
changed the title
This comment was marked as off-topic.
This comment was marked as off-topic.
cm13-github
added
the
Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
If the decision is reached that this is approved shouldn't 'Bronze Heart Medal' also be included since it is a lower status or at best an equal medal of 'Medal of Distinguished Conduct' ? 'Medal of Exceptional Heroism' and 'Medal Of Valor' should remain CO whitelisted awards as they are very grand awards but the other two medals seem perfectly acceptable for a Captain to hand out. |
cm13-github
removed
the
Merge Conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
About the pull request
XO can award distinguished conduct medals.
Explain why it's good for the game
We already have an non-WLed role that can give out medals and it wasn't a big issue. LRP is already against the rules for XO, so why not? Arguably XO is more motivated to give out medals than CO (deployed and perma) and we don't have a CO every round, so I think it would be fine.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑 ihatethisengine
add: XO can award distinguished conduct medals.
/:cl: