Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PO can remove queens override again, bit by bit edition #5143

Merged
merged 12 commits into from
Dec 7, 2023

Conversation

ihatethisengine
Copy link
Contributor

@ihatethisengine ihatethisengine commented Dec 6, 2023

About the pull request

PO can perform a 20 seconds do_after to remove additional 20 seconds of the lockdown.

Explain why it's good for the game

You used to be able to remove lockdown completely if you perform a 3 minutes do_after, but it was lost during the port to new shuttle system. Now it's back in another, better form! Gives marines a chance to remove lockdown sooner if they control the cockpit. In best case scenario you can remove the lock in 5 minutes.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 ihatethisengine
balance: PO can remove queens dropship override again.
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Dec 6, 2023
@ihatethisengine

This comment was marked as outdated.

Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good approach to basically put it in milestones to chip away at it so it's not super detrimental to get interrupted; but I think you ought to have it repeat the do_after again much like filling sandbags or clearing snow. Likely as simple as adding a while loop we break out of if interrupted but double check those implementations.

code/modules/shuttle/computers/dropship_computer.dm Outdated Show resolved Hide resolved
@Zonespace27 Zonespace27 added Confirmed Bug We have the same at home! Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. and removed Confirmed Bug We have the same at home! labels Dec 7, 2023
@ihatethisengine
Copy link
Contributor Author

ihatethisengine commented Dec 7, 2023

Theoretically you can have several people at once removing the lock, not sure if I should fix this. It kinda makes sense. In most cases if you are lucky you can have a synth to help you removing the lock, reducing the unlocking time to about 3.3 minutes. Though, if you are very lucky and have two synths, it can become too fast. If you have an ASO on top of it, this can become ridiculous...

UPD: added a snowflake implementation of action_busy :clueless: after all

@Drulikar
Copy link
Contributor

Drulikar commented Dec 7, 2023

Just to note automatic timer is 10 minutes. If you start early and don't get interrupted, you can get this down to ~3-4 minutes.

@harryob harryob added this pull request to the merge queue Dec 7, 2023
Merged via the queue into cmss13-devs:master with commit 2e04468 Dec 7, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants