Fixes Warrior Pulls continuously breaking after lunging a M56D/M2C user from front #5151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #5103 |
Co-authored-by: BeagleGaming1 <[email protected]>
3 tasks
fira
changed the title
harryob
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
So that one took a lot of debugging...
To keep it as short as possible, when you lunge a M56D/M2C user from front as Warrior, they get stunned. The stun cancels their HMG interaction, causing them to step away. This means they leave the grab range, breaking it. Warrior code incorrectly re-sets pulledby, resulting in a mob "pulledby" one that doesn't pull it.
In practice once this happens, this means that the "incorrectly" pulled mob will reset any active grabs from the Warrior when it moves. Negating the use of lunges completely.
Changelog
🆑 Firartix, Birdtalon
fix: Fixed a logic error in Warrior code causing lunging some M2C/M56D users to semi-permanently brick lunge.
/:cl: