Balloon Alerts for Gun Safety #5152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Birdtalon
reviewed
Dec 7, 2023
| @@ -1933,8 +1934,8 @@ not all weapons use normal magazines etc. load_into_chamber() itself is designed | |||
|
|
|||
| if(gun_user.client?.prefs?.toggle_prefs & TOGGLE_HELP_INTENT_SAFETY && (gun_user.a_intent == INTENT_HELP)) | |||
| if(world.time % 3) // Limits how often this message pops up, saw this somewhere else and thought it was clever | |||
Birdtalon
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
When attempting to shoot a gun while safety is on (either the gun safety itself or triggering help intent safety) you'll get a balloon alert informing you.
help intent safety is on (will be in lowercase):
gun safety toggled on:
also decreases the size of the "Help intent safety is on! Switch to another intent to fire your weapon." message to normal size.
Explain why it's good for the game
Reading chat when you're (presumably) in the middle of trying to shoot at a xeno is quite hard, having it as a balloon alert allows you to quickly realize what's happening.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
qol: Gun safety messages now use balloon alerts.
/:cl: