Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes the enter key submit a search in the game panel #5161

Closed
wants to merge 1 commit into from

Conversation

SabreML
Copy link
Member

@SabreML SabreML commented Dec 7, 2023

About the pull request

Edits the 'Create Object/Mob/Turf' interface so that pressing enter in the input bar will search for its value, rather than having to manually press the 'Search' button.
I also kept the previous functionality of the enter key spawning the first item in the results list. It seems a bit like an unintended "feature", but maybe it's used a lot by admins idk. (I can always just remove it in this PR if not.)

Explain why it's good for the game

It slightly bugs me when I'm testing stuff
It makes it easier/more intuitive for admins to spawn atoms.

Changelog

🆑
admin: Made the enter key submit a search in the 'Create Object/Mob/Turf' panel.
/:cl:

@github-actions github-actions bot added the Admin Make things harder for admins label Dec 7, 2023
@fira
Copy link
Member

fira commented Dec 8, 2023

You can already use spawn command with partial paths for this, I honestly wanted to just remove this window

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Dec 16, 2023
@SabreML SabreML closed this Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Make things harder for admins Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants