Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes the welder deconstruction hint from resin walls #5163

Merged
merged 2 commits into from
Dec 9, 2023

Conversation

SabreML
Copy link
Member

@SabreML SabreML commented Dec 8, 2023

About the pull request

Adds a check to /turf/closed/wall/get_examine_text() to remove the deconstruction hint for anything with the TURF_ORGANIC flag (currently only resin walls).

Explain why it's good for the game

Given that resin walls/membranes can't actually be deconstructed with tools, it doesn't make much sense to show that message.

Testing Photographs and Procedure

Screenshots & Videos

Before:
old

After:
new

Changelog

🆑
fix: Fixed resin walls/membranes showing a welder deconstruction hint.
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Dec 8, 2023
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-arrange this proc around some. The damage states are still relevant.

@SabreML
Copy link
Member Author

SabreML commented Dec 8, 2023

Re-arrange this proc around some. The damage states are still relevant.

Oh whoops. I guess that's what happens when you code past midnight.

Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before (missing icon is just because its previous round):
image

After:
image

@harryob harryob added this pull request to the merge queue Dec 9, 2023
Merged via the queue into cmss13-devs:master with commit d3f6827 Dec 9, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants