Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Projectile ref clears #5164

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Conversation

Doubleumc
Copy link
Contributor

@Doubleumc Doubleumc commented Dec 8, 2023

About the pull request

Forgot to clear a reference I set in #4986 and cleared some others I saw.

Not familiar enough with the Destroy/QDEL pipeline to know what else, if anything, should be done with weapon_cause_data and bullet_traits since they hold references themselves.

Explain why it's good for the game

I will clean up after myself.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

No player-facing changes.

Copy link
Member

@fira fira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weapon_cause_data can be discarded without qdel
i'm not really seeing where bullet_traits have refs, do you have a specific location in mind?

@Doubleumc
Copy link
Contributor Author

weapon_cause_data can be discarded without qdel i'm not really seeing where bullet_traits have refs, do you have a specific location in mind?

My understanding was bullet_traits were components, which do a lot of things but at the very least contained a parent ref to the holding projectile. Not familiar enough to know if that is handled gracefully - probably fine as-is since its been working without this change for a long time.

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Dec 16, 2023
@fira fira added this pull request to the merge queue Dec 19, 2023
Merged via the queue into cmss13-devs:master with commit 9cdddd4 Dec 19, 2023
28 checks passed
@Doubleumc Doubleumc deleted the projectile-ref-clears branch December 20, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants