Fixes camera EMP sprites #5168
Merged
Fixes camera EMP sprites #5168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Fixes the
icon_stateof cameras changing to the mapping helper sprite after being EMPed.This was caused by the
initial(icon_state)calls in/obj/structure/machinery/camera/emp_act(), which were setting its sprite to"autocam_editoremp"and"autocam_editor".To fix it, I modified
update_icon()so that it handles all of the camera's states, and made everything just use that. (Plus a tiny refactor ofemp_act().)Explain why it's good for the game
Mapping helpers shouldn't be visible in-game.
Testing Photographs and Procedure
Screenshots & Videos
I can't really do comparison videos since it takes 90 seconds for the EMP to wear off, but here's what was happening previously:
Changelog
🆑
fix: Fixed camera sprites changing to their mapping helper after being EMPed.
/:cl: