Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newpizzacutter #5178

Closed
wants to merge 7 commits into from
Closed

Newpizzacutter #5178

wants to merge 7 commits into from

Conversation

Mensla
Copy link
Contributor

@Mensla Mensla commented Dec 10, 2023

About the pull request

Adds two new pizza cutter sprites, one with a plastic handle and one with a wooden handle. Adds item sprites and hand-holding sprites.

No more comically large pizza cutter as they're now appropriately sized sprites in your hand.

Explain why it's good for the game

Allows for people to use a normal and non-memey pizza cutter.

Testing Photographs and Procedure

Screenshots & Videos

image
image

Changelog

🆑
add: Added new pizza cutter sprites.
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Feature Feature coder badge labels Dec 10, 2023
@Mensla Mensla closed this Dec 10, 2023
@Mensla Mensla reopened this Dec 10, 2023
@Mensla Mensla marked this pull request as ready for review December 10, 2023 07:25
@Mensla
Copy link
Contributor Author

Mensla commented Dec 10, 2023

Sorry for the unspaced PR name

Copy link
Member

@fira fira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make one subtype of another, that'll be easier to use and more compact
bonus points if you also integrate the old cutter into that
also you could have "wood" matter in the wooden one but that's a meme 👌

@Mensla
Copy link
Contributor Author

Mensla commented Dec 11, 2023

I created subtypes and I think they're done correctly (?).

Moved the meme pizza cutter under kitchen tools for organization.

I have zero idea why the compile maps is failing...

@Birdtalon
Copy link
Contributor

Birdtalon commented Dec 12, 2023

I created subtypes and I think they're done correctly (?).

Moved the meme pizza cutter under kitchen tools for organization.

I have zero idea why the compile maps is failing...

maps/map_files/FOP_v3_Sciannex/sprinkles/30.pizzatime.dmm:308:error: undefined type: /obj/item/weapon/pizza_cutter
maps/map_files/FOP_v3_Sciannex/sprinkles/30.pizzatime.dmm:312:error: unknown type

This map file is looking for the typepath which you have changed.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Dec 14, 2023
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@nauticall nauticall added the Sprites Approved confirmed no stray pixels label Dec 17, 2023
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Dec 25, 2023
@Birdtalon
Copy link
Contributor

Resolve conflicts please this is ready to merge otherwise.

@github-actions github-actions bot removed the Stale beg a maintainer to review your PR label Dec 27, 2023
Copy link
Contributor

github-actions bot commented Jan 3, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jan 3, 2024
@github-actions github-actions bot closed this Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Merge Conflict PR can't be merged because it touched too much code Sprites Approved confirmed no stray pixels Sprites Remove the soul from the game. Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants