-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ap rocket stun and damage consistency and renames vars in rocket.dm #5183
Ap rocket stun and damage consistency and renames vars in rocket.dm #5183
Conversation
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…renames-vars-in-rocket.dm
Conflicts have been resolved. A maintainer will review the pull request shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please detail the changelog a bit more regarding the move of stuns 2 and 4 to 3
…renames-vars-in-rocket.dm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pending updated changelog from firas review
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
About the pull request
renames one latter vars in rocket.dm. Makes AP rocket behavior more consistent, AP rocked stuns you for TWICE as longs when it lands on turf under the mob and does not hit it directly. to compensate that I increased the stun duration by 50% to avrage of the turf hit and mob hit. the PR also reduces max distance damage, as it was higer for no aperent reason
but I will not fight agains it if maintainer decides that the values should be diferent, I do not care.
Explain why it's good for the game
expecting 2,6 sec stun and geting 5.3 when someone knows to aim for the tile under you and not you is not fun.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑
balance: AP rocket applies 3 weaken and 3 paralyze no matter if you hit the mob directly(from 2), at max range (from 2) or tile under it (from 4)
balance: indirect AP rocket does the same damage to walls and mobs
/:cl: