Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ap rocket stun and damage consistency and renames vars in rocket.dm #5183

Conversation

cuberound
Copy link
Contributor

@cuberound cuberound commented Dec 10, 2023

About the pull request

renames one latter vars in rocket.dm. Makes AP rocket behavior more consistent, AP rocked stuns you for TWICE as longs when it lands on turf under the mob and does not hit it directly. to compensate that I increased the stun duration by 50% to avrage of the turf hit and mob hit. the PR also reduces max distance damage, as it was higer for no aperent reason
but I will not fight agains it if maintainer decides that the values should be diferent, I do not care.

Explain why it's good for the game

expecting 2,6 sec stun and geting 5.3 when someone knows to aim for the tile under you and not you is not fun.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
balance: AP rocket applies 3 weaken and 3 paralyze no matter if you hit the mob directly(from 2), at max range (from 2) or tile under it (from 4)
balance: indirect AP rocket does the same damage to walls and mobs
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Dec 10, 2023
@Birdtalon Birdtalon added the Code Improvement Make the code longer label Dec 11, 2023
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Dec 19, 2023
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Dec 19, 2023
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Dec 19, 2023
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the Stale beg a maintainer to review your PR label Dec 20, 2023
@Zonespace27 Zonespace27 added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Dec 22, 2023
fira
fira previously requested changes Dec 26, 2023
Copy link
Member

@fira fira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please detail the changelog a bit more regarding the move of stuns 2 and 4 to 3

code/datums/ammo/rocket.dm Outdated Show resolved Hide resolved
code/datums/ammo/rocket.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar marked this pull request as draft December 31, 2023 08:51
@cuberound cuberound requested a review from fira January 2, 2024 23:54
@cuberound cuberound marked this pull request as ready for review January 2, 2024 23:55
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending updated changelog from firas review

@harryob harryob marked this pull request as draft January 6, 2024 14:55
@cuberound cuberound requested a review from harryob January 7, 2024 10:27
@cuberound cuberound marked this pull request as ready for review January 11, 2024 11:00
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jan 19, 2024
@harryob harryob added this pull request to the merge queue Jan 21, 2024
Merged via the queue into cmss13-devs:master with commit 41105d3 Jan 21, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Code Improvement Make the code longer Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants