Modify organization for vendors of the Rifleman and the Team Leader role. #5187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 11, 2023 11:19
github-actions
bot
added
Quality of Life
Zonespace27
requested changes
Dec 16, 2023
code/game/machinery/vending/vendor_types/squad_prep/squad_rifleman.dm
Outdated
Show resolved
Hide resolved
code/game/machinery/vending/vendor_types/squad_prep/squad_tl.dm
Outdated
Show resolved
Hide resolved
capitalize
capitalize
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
Drulikar
approved these changes
Dec 30, 2023
Drulikar
added
the
Balance Approved
cm13-github
added a commit
that referenced
this pull request
Dec 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
added binocular to rifleman because he access to the higher tier of it already.
added the advance tier to team leader because their is no reason for rifleman to have it and not their leader.
added the section because it's a section other job have to store engi item(SL and comtech)
Explain why it's good for the game
better logic on what items are available for marines for binoculars change.
the new section is on other job so it will probably make it better to orient ourself in vendors.
the two new item because i think they aren't OP and are under-used items that some marine might take if they can buy them.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
qol: creating a new section called engineering supplies for the rifleman and the team leader.
balance: added standard binocular to the rifleman vendor at a cost of 5.
balance: added Range Finder and Laser Designator binoculars to Team leader at a cost of 10 and 20.
balance: added ES-11 Mobile Fuel Canister and ME3 hand welder to Team leader and rifleman for 5 each.
/:cl: