Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compass Headgear now shows your direction when examined #5198

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

Contrabang
Copy link
Contributor

@Contrabang Contrabang commented Dec 12, 2023

About the pull request

When the compass headgear is now examined, it will tell you the direction your character is facing (north, south, east, or west). This only works when you're on a planet, this means being groundside and not on a map that is situated in space.

I've considered changing the description, but I've left it because I couldn't think of a better one.

Explain why it's good for the game

When I used the compass in game, I expected to actually tell me which direction I'm facing, but I was a bit disappointed when it didn't. So, I change it to work in a realistic way.

Testing Photographs and Procedure

Screenshots & Videos

On LV-624, where the compass works (left). On the ship, were the compass does not work (right).
image

On maps like Fiorina where are situated in space, the compass will not work.
image

Changelog

🆑
add: The compass headgear will now tell you what direction you're facing when on a planet.
code: Added a new ground environmental trait for a ground level in space.
/:cl:
My discord is: contrabang, if you would like to contact me, that is the best place.

@github-actions github-actions bot added Feature Feature coder badge Code Improvement Make the code longer labels Dec 12, 2023
@Contrabang Contrabang changed the title a working compass? preposterous Compass Headgear now shows your direction when examined Dec 12, 2023
@Contrabang
Copy link
Contributor Author

I forgot to change the title, embarrassing

@BadAtThisGame302
Copy link
Contributor

Shouldn't you also change the desc of the compass? "It always faces north"... well now it won't always face 'north'.

@Contrabang
Copy link
Contributor Author

Shouldn't you also change the desc of the compass? "It always faces north"... well now it won't always face 'north'.

I mean, the needle of a compass always does point north, that's how you determine your rotation. Its a bit of a silly description, but I can't think of a better one, so I left it

@harryob harryob added this pull request to the merge queue Dec 13, 2023
Merged via the queue into cmss13-devs:master with commit 8b96435 Dec 13, 2023
28 checks passed
cm13-github added a commit that referenced this pull request Dec 13, 2023
@BottleBook
Copy link

BottleBook commented Dec 17, 2023

Its a bit of a silly description, but I can't think of a better one

What about "It always points towards the north"?

@Contrabang Contrabang deleted the compass branch January 24, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Make the code longer Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants