Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor QOL things for xeno special structure construction #5201

Merged
merged 6 commits into from
Dec 18, 2023

Conversation

SabreML
Copy link
Member

@SabreML SabreML commented Dec 12, 2023

About the pull request

  1. Updates the 'help' message descriptions for xeno special structures, and refactors them a bit to use the pre-existing /datum/construction_template/var/description variable rather than a global proc.
  2. Adds a 'remaining' counter to the special structure construction message to let players know how many can still be built.
  3. Removes a redundant check in code/modules/mob/living/carbon/xenomorph/abilities/general_powers.dm.
  4. Removes a couple of unused special structure defines. ("Unused" as in there was no structure datum tied to them, just a few references.)

Explain why it's good for the game

Just a little QOL thing, because I noticed that the limit and sometimes the function of some structures isn't very widely known.

Testing Photographs and Procedure

Screenshots & Videos

Before:

Help message:
help before

Construction messages:
core before
cluster before
recovery before
morpher before

After:

Help message:
help after

Construction messages:
core after
cluster after
recovery after
morpher after

Changelog

🆑
add: Updated the 'help' message for xeno special structure construction.
qol: Added a 'remaining' counter when constructing special structures to let players know how many can still be built.
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Dec 12, 2023
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Dec 15, 2023
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Dec 15, 2023
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@Birdtalon Birdtalon self-assigned this Dec 18, 2023
@Birdtalon Birdtalon added the Quality of Life Make the game harder to play label Dec 18, 2023
@Birdtalon Birdtalon added this pull request to the merge queue Dec 18, 2023
Merged via the queue into cmss13-devs:master with commit 4372536 Dec 18, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Quality of Life Make the game harder to play
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants