Adds a way for SLs/SOs/XOs to recommend medals that the CO can then approve/deny. #5202
Conversation
There was a problem hiding this comment.
Code and functionality appears to be okay.
Only thing I really think could be improved would be to reuse the DM defines for the human_medals rather than having now two separate definitions for the medals. But it may be better to just create a unit test for this in the future ever people start changing medals.
Drulikar
added
the
Testmerge Candidate
|
The |
|
If the ASO, a staff officer, tries to give a medal out, they receive this message. 'Only Staff Officers, Executive Officers and Squad Leader are permitted to give medal recommendations!' |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
# About the pull request As title. This PR continues my work from #5128 and adds the defines for PMCs, Mercenaries, VAI and TWE. I have also changed how the global lists for highcommand (both USCM and WY) work and have made a new global list of all USCM officers to allow for easy reference in #5202. To do the above I have added a default_faction var on paygrades, along with a variable to indicate if a paygrade refers to an "officer" or not, and if the officer is a "flag" officer, for senior leadership. I have also updated the Syndicate ID card to work properly. <!-- Remove this text and explain what the purpose of your PR is. Mention if you have tested your changes. If you changed a map, make sure you used the mapmerge tool. If this is an Issue Correction, you can type "Fixes Issue #169420" to link the PR to the corresponding Issue number #169420. Remember: something that is self-evident to you might not be to others. Explain your rationale fully, even if you feel it goes without saying. --> # Explain why it's good for the game # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> Put screenshots and videos here with an empty line between the screenshots and the `<details>` tags. </details> # Changelog :cl: add: Adds paygrade defines for PMCs, VAI, Mercenaries and TWE. code: Adds code to populate reference lists for certain paygrades. fix: Fixes PMC synth not using the correct grade. add: Syndicate ID card repathed and works with paygrades. /:cl:
About the pull request
See title
Explain why it's good for the game
Will likely make medals more used, and means the CO doesn't have to scramble to get medal recommendations in the last 3 minutes.
Testing Photographs and Procedure
Screenshots & Videos
How to give recommendations:
OR
The actual panel for COs:
Changelog
🆑
add: SLs, SOs and XOs can now recommend people for medals! Do this by right-clicking your headset, or using the new button in the object panel of the Status Panel!
/:cl: