Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprite change of chocolate bar #5203

Merged
merged 6 commits into from
Dec 18, 2023
Merged

Conversation

PurpleCIoud
Copy link
Contributor

@PurpleCIoud PurpleCIoud commented Dec 12, 2023

About the pull request

Updates the chocolate bar sprite to something better

Explain why it's good for the game

old sprite is very old, new sprite fixes that

Testing Photographs and Procedure

Screenshots & Videos

image

Changelog

🆑
imageadd: added chocolate bar new sprite
imagedel: deleted old chocolate bar sprite

/:cl:

@github-actions github-actions bot added the Sprites Remove the soul from the game. label Dec 12, 2023
@BeagleGaming1
Copy link
Contributor

Could you do a more descriptive title?

@PurpleCIoud PurpleCIoud changed the title Sprite change Sprite change of chocolate bar Dec 12, 2023
@PurpleCIoud
Copy link
Contributor Author

sorry tried to fix image not showing up in the description

@SabreML
Copy link
Member

SabreML commented Dec 12, 2023

sorry tried to fix image not showing up in the description

You have to add an empty line above the image (for some reason).

@PurpleCIoud PurpleCIoud marked this pull request as draft December 12, 2023 18:40
@PurpleCIoud PurpleCIoud marked this pull request as ready for review December 12, 2023 21:35
@fira
Copy link
Member

fira commented Dec 14, 2023

It's OK anyway the images are accessible in Checks > Icon Diff Bot
the new one looks kinda blurry with perspective

Copy link
Contributor

@nauticall nauticall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sprites 👍

@nauticall nauticall added the Sprites Approved confirmed no stray pixels label Dec 17, 2023
@Birdtalon Birdtalon added this pull request to the merge queue Dec 18, 2023
Merged via the queue into cmss13-devs:master with commit 1cc75f2 Dec 18, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sprites Approved confirmed no stray pixels Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants