-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requisitions elevator lighting fix #5204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been looking for it for months and i never realized there were turfs instanciations here!!!!! I feel so stupid!!!! AGHHH thanks so much
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues noted from testmerges.
About the pull request
This PR fixes the elevator lighting by changing the way the turf cloning logic works to use the pre-existing ChangeTurf function, which will result in the static lighting properties being copied properly. By doing this change, we can disable the base lighting properties from the shuttle area and have the static lighting system apply to the elevator turf in requisition which is consistent with how the room lighting already works.
Explain why it's good for the game
The existing elevator has many visual effect issues, requiring other forms of lighting to compensate for the problem, such as placing movable lights (flashlight), or other non-static lighting sources. Without these work arounds the elevator will be completely black after the first time the space turfs are cloned.
Testing Photographs and Procedure
Screenshots & Videos
Before
before.mp4
After
after.mp4
Changelog
🆑
fix: Requisitions elevator lighting fix
/:cl: