Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xeno telegraph effect can now be any rgb colour #5207

Merged
merged 4 commits into from
Dec 15, 2023

Conversation

Birdtalon
Copy link
Contributor

@Birdtalon Birdtalon commented Dec 12, 2023

About the pull request

I didn't want it to be locked into the basic colours we have based on the sprites, so instead you can supply a colour code to the constructor to create any colour you want. Defaults to white if none provided. Eventually would be good to roll this out also the animated sprites.

Explain why it's good for the game

When we add new castes/xenos we can diversify the colour palette for different effects instead of everything being red or brown.

bandicam_2023-12-12_20-59-34-534.mp4

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Xenomorph telegraph effects can now be any rgb colour.
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Feature Feature coder badge labels Dec 12, 2023
@Red-byte3D

This comment was marked as spam.

@Red-byte3D

This comment was marked as spam.

@BeagleGaming1
Copy link
Contributor

What about the animated telegraphs? and you removed the green and brown iconstates but not the red one

@Birdtalon
Copy link
Contributor Author

I'd quite like to actually use the animated telegraphs sometime. Eventually I'll get around to converting those also. They're unused currently.

Copy link
Contributor

@FransFeiffer FransFeiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as sprites go this sprite is fine so take my approval

@FransFeiffer FransFeiffer added the Sprites Approved confirmed no stray pixels label Dec 14, 2023
code/game/objects/effects/aliens.dm Outdated Show resolved Hide resolved
code/game/objects/effects/aliens.dm Outdated Show resolved Hide resolved
code/game/objects/effects/aliens.dm Show resolved Hide resolved
@Drulikar Drulikar added this pull request to the merge queue Dec 15, 2023
Merged via the queue into cmss13-devs:master with commit 20db6e3 Dec 15, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Dec 15, 2023
@Birdtalon Birdtalon deleted the effecttest branch December 21, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Sprites Approved confirmed no stray pixels Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants