Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed hard hat user inventory head icon #5216

Merged
merged 1 commit into from Dec 14, 2023
Merged

Fixed hard hat user inventory head icon #5216

merged 1 commit into from Dec 14, 2023

Conversation

ghost
Copy link

@ghost ghost commented Dec 14, 2023

About the pull request

In the recent PR #5189 the action item for the hard hat was fixed. However because the icon was being turned on in hand instead of on head, it was overlooked that the user inventory head icon was also incorrect at times, specifically when turned on while the user is wearing it. This PR is related to the previous change mentioned because the update_icon call must occur first, due to the fact that both update_button_icon and update_inv_head both reference the icon and item state properties.

Explain why it's good for the game

It is desirable for the icon state to be consistent in all situations. We want the light icon to show as shining when light is being emitted.

Testing Photographs and Procedure

This update was tested both in hand and on head, as well as off states. The bug is reliably observable when the hard hat is activated while on head, however when in hand and placed on head in the on state, the bug does not occur. Upon various testing I have been unable to cause the icon to be in an inconsistent state.

Screenshots & Videos

Before

before

After

fixed

Changelog

🆑
fix: Fixed hard hat user inventory head icon
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Dec 14, 2023
@ghost
Copy link
Author

ghost commented Dec 14, 2023

I wasn't sure how to properly word it but this fixes the actual sprite. This picture demonstrates the bug.

beforesprite

@harryob harryob merged commit b82432f into cmss13-devs:master Dec 14, 2023
28 checks passed
cm13-github added a commit that referenced this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants