Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic price for omnisentryguns #5226

Closed

Conversation

cuberound
Copy link
Contributor

@cuberound cuberound commented Dec 16, 2023

About the pull request

Adds dinamic price to sentrguns, starts at 300 and goes up 100 points after each purchase. Aims to keep the anti spam meshures in place (makes them stricter in fact), while allowing players to purchase few of them for reasonable price.

Explain why it's good for the game

Please before you put angry comments read this.

Omnisentryguns are not used at all, and that is a shame, due to the changes that were were put in place to prevent sentryspam(they also weakened the sentrgun a lot along the way, it was not just price change) , but made them too expensive to buy just one.

This PR changes it by setting the initial price to 300 and it goes up 100 points after each purchase.
This makes it so that no pilot has reason to not buy at least one.
It is balanced around 3 sentrguns for 400 points each, 5 sentrguns 500 points each ( old price) and 11 sentryguns 800 points each(that means for 8800 points, same as now), and if you try to buy more then current roundstart maximum of 11, they will cost more then they do now on avarage.

This should enshure that FTLs and engineers can count with 1- 3 sentryguns each round and plan acordingly, decide if they want some for FOB, comms and hopfuly have one left to set up frontal outpost.

In terms of effect on xeno gameplay, the sentrygun is quite weak after the nerfs, alone it can be taken down by basicly any two xenos with just a bit of efford and fold when t3 or defender attacks it. That means it serves the intended purpose, covering medics and engineers from skirmish castes, while slightly helping agains bigger threats while it is part of defended outpost.

Please mind that the sentryguns can not be moved, so when marines overextend past it or are forced to retreat from it the sentry is good as dead.

In terms of pilot gameplay it kind of nerfs experienced pilots who get loads of calls as they will be expected to spend some points on sentryguns and have less ammo as resoult and less expirienced pilots who would not be able to make use of the ammo anyway are given another tool that is easier to use and makes them contribute to the round.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
balance: omnisentrygun price down to 300, but it goes up 100 points after each purchase
/:cl:

@github-actions github-actions bot added UI deletes nanoui/html Balance You need to be a professional veteran game maintainer to comprehend what is being done here. labels Dec 16, 2023
@cuberound cuberound changed the title Dinamic price for omnisentryguns Dynamic price for omnisentryguns Dec 16, 2023
@ghost
Copy link

ghost commented Dec 23, 2023

It should probably cap out at a certain price.

code/modules/cm_marines/vehicle_part_fabricator.dm Outdated Show resolved Hide resolved
code/modules/cm_marines/vehicle_part_fabricator.dm Outdated Show resolved Hide resolved
tgui/packages/tgui/interfaces/PartFabricator.js Outdated Show resolved Hide resolved
@Zonespace27 Zonespace27 marked this pull request as draft December 26, 2023 03:44
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Dec 29, 2023
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Accoint Accoint mentioned this pull request Jan 1, 2024
3 tasks
@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Jan 3, 2024
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cuberound cuberound marked this pull request as ready for review January 3, 2024 12:38
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jan 11, 2024
@github-actions github-actions bot closed this Jan 19, 2024
github-merge-queue bot pushed a commit that referenced this pull request Feb 28, 2024
# About the pull request

just copy of #5226 but gona
place it all here too

Adds dinamic price to sentrguns, starts at 300 and goes up 100 points
after each purchase. Aims to keep the anti spam meshures in place (makes
them stricter in fact), while allowing players to purchase few of them
for reasonable price.



# Explain why it's good for the game

Please before you put angry comments read this.

Omnisentryguns are not used at all, and that is a shame, due to the
changes that were were put in place to prevent sentryspam(they also
weakened the sentrgun a lot along the way, it was not just price change)
, but made them too expensive to buy just one.

This PR changes it by setting the initial price to 300 and it goes up
100 points after each purchase.
This makes it so that no pilot has reason to not buy at least one.
It is balanced around 3 sentrguns for 400 points each, 5 sentrguns 500
points each ( old price) and 11 sentryguns 800 points each(that means
for 8800 points, same as now), and if you try to buy more then current
roundstart maximum of 11, they will cost more then they do now on
avarage.

This should enshure that FTLs and engineers can count with 1- 3
sentryguns each round and plan acordingly, decide if they want some for
FOB, comms and hopfuly have one left to set up frontal outpost.

In terms of effect on xeno gameplay, the sentrygun is quite weak after
the nerfs, alone it can be taken down by basicly any two xenos with just
a bit of efford and fold when t3 or defender attacks it. That means it
serves the intended purpose, covering medics and engineers from skirmish
castes, while slightly helping agains bigger threats while it is part of
defended outpost.

Please mind that the sentryguns can not be moved, so when marines
overextend past it or are forced to retreat from it the sentry is good
as dead.

In terms of pilot gameplay it kind of nerfs experienced pilots who get
loads of calls as they will be expected to spend some points on
sentryguns and have less ammo as resoult and less expirienced pilots who
would not be able to make use of the ammo anyway are given another tool
that is easier to use and makes them contribute to the round.


# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog
:cl:
balance: omnisentrygun price down to 300, but it goes up 100 points
after each purchase
/:cl:

---------

Co-authored-by: Zonespace <[email protected]>
Co-authored-by: vincibrv <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Stale beg a maintainer to review your PR UI deletes nanoui/html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants