Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returns Ice V2 to rotation for the Holiday Season #5242

Closed
wants to merge 47 commits into from

Conversation

private-tristan
Copy link
Contributor

@private-tristan private-tristan commented Dec 17, 2023

About the pull request

thanks to Drathek and vilebeggar for their help with this PR.
Ice v2, with functional elevators and Intel, for the chilly season. this PR copies code and ice v1 from #5067
Ice_Colony_2 low quality
(quality a bit low because it needed to be compressed for github)

Explain why it's good for the game

I want to play ice v2.

Testing Photographs and Procedure

I tested elevators and elevator buttons, and they all seem to work fine.

@github-actions github-actions bot added Sprites Remove the soul from the game. Mapping did you remember to save in tgm format? labels Dec 17, 2023
@BadAtThisGame302
Copy link
Contributor

How about we return CORSAT and prisonblocks back to rotation because it's the Holiday Season and we have to spread the cheer equally among all dropped maps? One Ice was bad enough.

@Googles-Hands
Copy link
Contributor

Let's hope you manage to do what I couldn't, but I agree, one ice is enough.
Ask the maintainers to un-testmerge the other ice once this is ready. That seems like a reasonable solution to me.

@private-tristan
Copy link
Contributor Author

all these runtime failures because I forgot how subtypes work 😭 I need to actually make a map for the maps ingame to work because I can't find one online

@private-tristan private-tristan marked this pull request as ready for review December 19, 2023 21:53
@private-tristan
Copy link
Contributor Author

Pr is ready to be TM'd.

@Nanu308 Nanu308 added Do Not Merge If you merge this PR, I will annihilate you Test Merge Only This PR's purpose is for testmerges only. labels Dec 21, 2023
@private-tristan private-tristan changed the title Returns Ice V2 (and classic) to rotation for Holiday Season Returns Ice V2 to rotation for the Holiday Season Dec 23, 2023
Copy link
Contributor

github-actions bot commented Jan 3, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jan 3, 2024
@harryob
Copy link
Member

harryob commented Jan 6, 2024

the holidays are over. jollyness completed

@harryob harryob closed this Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge If you merge this PR, I will annihilate you Mapping did you remember to save in tgm format? Sprites Remove the soul from the game. Stale beg a maintainer to review your PR Test Merge Only This PR's purpose is for testmerges only.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants