-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Steelpoint Donor Armour Update #5252
Conversation
code lgtm |
Grammar corrected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look fine.
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fits overall but as advice please be mindful of injecting camouflage bits into armor, we don't do that on normal armor/uniforms for a reason. 👍
About the pull request
Effects a sprite update to the M4X Armour (Donor Armour). Also changes the item description to be more in-universe, and adds alt-camo options for the armour based on the map type.
All credit to @Zenith for the sprite work. Camo sprites are my doing.
Updates to donor gear are allowed based on my review of past PRs.
Explain why it's good for the game
Updating 2015 sprites to 2023 standards is good.
Testing Photographs and Procedure
Changelog
🆑 Zenith, Steelpoint
add: Updates Steelpoint's donor armour, replacing it with a new sprite, camouflage options for all maps and new item descriptions that are lore friendly.
/:cl: