Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Steelpoint Donor Armour Update #5252

Merged
merged 7 commits into from
Jan 11, 2024
Merged

Conversation

Steelpoint
Copy link
Contributor

@Steelpoint Steelpoint commented Dec 19, 2023

About the pull request

Effects a sprite update to the M4X Armour (Donor Armour). Also changes the item description to be more in-universe, and adds alt-camo options for the armour based on the map type.

All credit to @Zenith for the sprite work. Camo sprites are my doing.

Updates to donor gear are allowed based on my review of past PRs.

Explain why it's good for the game

Updating 2015 sprites to 2023 standards is good.

Testing Photographs and Procedure

Screenshot 2023-12-20 12 43 35

Changelog

🆑 Zenith, Steelpoint
add: Updates Steelpoint's donor armour, replacing it with a new sprite, camouflage options for all maps and new item descriptions that are lore friendly.
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Feature Feature coder badge labels Dec 19, 2023
@mullenpaul
Copy link
Contributor

code lgtm

@Steelpoint
Copy link
Contributor Author

Grammar corrected

Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look fine.

@Drulikar Drulikar requested a review from a team December 30, 2023 10:07
Copy link
Contributor

github-actions bot commented Jan 7, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jan 7, 2024
Copy link
Contributor

@nauticall nauticall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fits overall but as advice please be mindful of injecting camouflage bits into armor, we don't do that on normal armor/uniforms for a reason. 👍

@nauticall nauticall added Sprites Approved confirmed no stray pixels and removed Stale beg a maintainer to review your PR labels Jan 11, 2024
@nauticall nauticall added this pull request to the merge queue Jan 11, 2024
Merged via the queue into cmss13-devs:master with commit 05b0bef Jan 11, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Jan 11, 2024
@Steelpoint Steelpoint deleted the Steelpoint branch January 11, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Sprites Approved confirmed no stray pixels Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants