Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Disposal Pipe Dispenser to Reactor Core Maintenance #5258

Closed

Conversation

Ben10083
Copy link
Contributor

@Ben10083 Ben10083 commented Dec 20, 2023

About the pull request

Disposal Pipe Dispenser added to Reactore Core Maintenance, allowing building/replacement of disposal pipes

Explain why it's good for the game

Almost every round disposal pipes are destroyed, allowing the crew to repair them will help allow MTs to do more to restore the ship (also allows them to expand the disposal system if they so choose)

Changelog

🆑
add: Disposal Pipe Dispenser added to Reactor Core Maintenance
/:cl:

@github-actions github-actions bot added Mapping did you remember to save in tgm format? Feature Feature coder badge labels Dec 20, 2023
@Nanu308
Copy link
Member

Nanu308 commented Dec 21, 2023

Going to reference #84

Why is it to be added back, what has changed since then to hinder these issues?

@Nanu308 Nanu308 added the Do Not Merge If you merge this PR, I will annihilate you label Dec 21, 2023
@Ben10083
Copy link
Contributor Author

Going to reference #84

Why is it to be added back, what has changed since then to hinder these issues?

What if I make a dispenser lite that just lets you spit out certain pipes (straight, junction, up/down, etc) without some of the more complex/abusable ones?

@Nanu308
Copy link
Member

Nanu308 commented Dec 25, 2023

Going to reference #84
Why is it to be added back, what has changed since then to hinder these issues?

What if I make a dispenser lite that just lets you spit out certain pipes (straight, junction, up/down, etc) without some of the more complex/abusable ones?

Gonne need to hear with a coder primarily or even @harryob / @Zonespace27 , basically, pipestuff is very unmaintained so if this is to be added back its gonne need approval from one of em 👍

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Dec 25, 2023
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Zonespace27
Copy link
Contributor

Thank you for the PR, but I will be closing this. As Nanu's said, disposals have been largely unmaintained and contribute little to shipside. If someone were to refactor the system, I could see this being readded. However, I don't feel like this is a worthwhile PR until then.

@Ben10083 Ben10083 deleted the Disposal_Pipe_Dispenser branch February 22, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge If you merge this PR, I will annihilate you Feature Feature coder badge Mapping did you remember to save in tgm format? Merge Conflict PR can't be merged because it touched too much code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants