Noticeboard refactor port + approved stamp #5283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Sprites
|
It still requires pens right? Could you map some in too while at it? As it stands reqs has paper and now the notice board but no pens |
Added a few |
Nanu308
previously requested changes
Dec 24, 2023
there is simply not much place for them |
fira
approved these changes
Dec 26, 2023
Drulikar
dismissed
Nanu308’s stale review
Mapping was approved after changes requested were resolved.
cm13-github
added a commit
that referenced
this pull request
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Ports noticeboard refactor from TG, also i've made a third button to be able to interact with paper on noticeboard with a pen, in order to write on it, mapped noticeboard in req, as well as added some pens to req area.
Also added green approved stamp, added it in QM's office.
Explain why it's good for the game
Just compare these two, i think it says it all.
Testing Photographs and Procedure
Screenshots & Videos
Changelog
🆑
add: added approved stamp
fix: fixed being unable to write on papers on noticeboard
ui: changed noticeboard UI from scratch
refactor: refactored noticeboard code
maptweak: added noticeboard to req and approved stamp to QM's office, as well as some pens in req area to interact with noticeboard
/:cl: