Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a 'Time Since Death' counter to the status tab #5314

Merged
merged 2 commits into from
Dec 30, 2023

Conversation

SabreML
Copy link
Member

@SabreML SabreML commented Dec 27, 2023

About the pull request

Adds a 'Time Since Death' counter to the status tab, which shows in minutes and seconds how long it's been since the player died.
(The counter isn't shown to players who joined as observers, just ghosts.)

(also for the record I asked and this is fine in regards to the freeze: https://discord.com/channels/150315577943130112/745447048261795890/1189329387397578912)

Explain why it's good for the game

Primarily, it would be very useful for tracking how long until it's possible to spawn as a lesser drone/facehugger without having to keep clicking the buttons to see the failure message.

Testing Photographs and Procedure

Screenshots & Videos

Normal:
after normal


With larva queue:
after with queue


With hijack:
after with hijack


With both:
after


Changelog

🆑
qol: Added a 'Time Since Death' counter to the status tab for ghosts.
/:cl:

@github-actions github-actions bot added the Quality of Life Make the game harder to play label Dec 27, 2023
@HeresKozmos
Copy link
Contributor

Pretty nice

@Drulikar Drulikar added this pull request to the merge queue Dec 30, 2023
Merged via the queue into cmss13-devs:master with commit dc43dbe Dec 30, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Dec 30, 2023
github-merge-queue bot pushed a commit that referenced this pull request Jan 4, 2024
# About the pull request

Tweaks the 'Time Since Death' counter added in #5314 so that it doesn't
wrap around to '00:00' when it reaches one hour, instead adding an hour
counter to the number.

I tried to see if I could make the minutes counter continue above 60
instead, but the best method I could figure out involved writing a whole
time parsing thing, plus something to add zero padding so that it would
display '61:02' and not '61:2', so I decided to just add a `>=` check
instead.

Technically this does just push the wrapping threshold back a bit rather
than actually fixing it, but if a round's been going for more than 24
hours then there's probably bigger problems.

# Explain why it's good for the game

Less confusing for ghosted players.

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>


https://github.com/cmss13-devs/cmss13/assets/57483089/cdc88e6b-ff1d-4a5a-a04f-b6f7a8abf4c4

(Runtime is unrelated, something to do with the DB I think?)

</details>


# Changelog
:cl:
fix: Made the 'Time Since Death' counter show hours if it passes 1 hour,
rather than wrapping the minutes back to 0.
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quality of Life Make the game harder to play
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants