'Time Since Death' hour wrapping fix #5374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drulikar
requested changes
Jan 3, 2024
thank you drulikar
Drulikar
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Tweaks the 'Time Since Death' counter added in #5314 so that it doesn't wrap around to '00:00' when it reaches one hour, instead adding an hour counter to the number.
I tried to see if I could make the minutes counter continue above 60 instead, but the best method I could figure out involved writing a whole time parsing thing, plus something to add zero padding so that it would display '61:02' and not '61:2', so I decided to just add a
>=check instead.Technically this does just push the wrapping threshold back a bit rather than actually fixing it, but if a round's been going for more than 24 hours then there's probably bigger problems.
Explain why it's good for the game
Less confusing for ghosted players.
Testing Photographs and Procedure
Screenshots & Videos
dreamseeker_aAX3JoOxs8.mp4
(Runtime is unrelated, something to do with the DB I think?)
Changelog
🆑
fix: Made the 'Time Since Death' counter show hours if it passes 1 hour, rather than wrapping the minutes back to 0.
/:cl: