Fixes xenos seeing raw html on paper

[ghost]

About the pull request

Continuation of #4654 , to fix #4609 . This fix should make it so that when xenos examine paper it no longer displays a blank page and the raw html was replaced with the formatted scrambled message.

Explain why it's good for the game

raw html is rather ugly

johnwick.mp4

Changelog

🆑
fix: fixes xenos being able to view raw html on paper.
/:cl:

[ghost]

For parity or anyone too lazy to view the comments on the old pr, they are as follows:

You also need to check for quotation marks inside of HTML tags. Consider a tag such as . So when you are inside an HTML tag and run into a quotation mark (either single ' or double "), then you advance until you find the matching quotation mark. Perhaps you could add a couple booleans for this, e.g. need_single_quote and need_double_quote.
Maybe it would be a bit overkill but it's probably good to be safe.

Carefully-crafted user input would make this replace text inside of HTML tags. This should be reworked to be a bit more similar to how /proc/stars works, where the final message is being appended to in the original for loop. In this case, you could be appending scrambled_string from the loop before to a variable representing the final output. I suspect that would also be better performance-wise compared to repeatedly searching through the whole text for replacements.
Your current code also means that duplicates of unscrambled_message_key would get the same star text, while doing it iteratively would preserve the original behavior of not duplicating star text instances.

[Drulikar]

At the moment this works, though it would be nice for at least the <style> block to not get scrambled:

Instead of:

(Normal view:)

If you would like to try or adapt my experiment supporting this, git apply this patch:
patch.diff.txt

Test procedure:

1. Load USS Runtime
2. Spawn "faxmachine
3. Send a blank fax
4. Admin reply to it with custom message w/ HTML
5. Inspect reply with a xeno