Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Overlay Lighting Fixes #5331

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

Drulikar
Copy link
Contributor

@Drulikar Drulikar commented Dec 29, 2023

About the pull request

This PR ports tgstation/tgstation#79939 and fixes a few other things in the overlay_lighting component.

Explain why it's good for the game

Less hard deletes and lights in objects disables the light (despite actually still being on).

Fixes:

light_master.mp4

Testing Photographs and Procedure

Screenshots & Videos

flares

light_fixed.mp4

Changelog

🆑 Drathek
refactor: Refactored the overlay_lighting component to better handle objects deleting
fix: Fix putting lights in bags somereason keeping the light on
/:cl:

@github-actions github-actions bot added Refactor Make the code harder to read Fix Fix one bug, make ten more labels Dec 29, 2023
@Drulikar Drulikar changed the title Port Overlay Hard Delete Fixes Port Overlay Lighting Fixes Dec 29, 2023
@fira
Copy link
Member

fira commented Dec 29, 2023

But isn't deletion of holder already handled?
Also inside loc will be null if it's deleted so that shouldn't hit this check (presumably...)

@Drulikar
Copy link
Contributor Author

But isn't deletion of holder already handled? Also inside loc will be null if it's deleted so that shouldn't hit this check (presumably...)

See the linked PR. They claim that check_holder() can occur after the qdel signal nulled it resulting in it un-nulling it.

Copy link
Member

@fira fira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly don't get it, datum Destroy should clear any signal preventing this issue - but i guess it's upstream's problem now

Copy link
Contributor

github-actions bot commented Jan 6, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jan 6, 2024
@harryob harryob added this pull request to the merge queue Jan 6, 2024
Merged via the queue into cmss13-devs:master with commit f064c58 Jan 6, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Jan 6, 2024
@Drulikar Drulikar deleted the Update_Overlay_Lighting branch January 8, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more Refactor Make the code harder to read Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants