-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uncluttering Queen UI P1 #5350
Uncluttering Queen UI P1 #5350
Conversation
code/modules/mob/living/carbon/xenomorph/abilities/queen/queen_powers.dm
Show resolved
Hide resolved
code/modules/mob/living/carbon/xenomorph/abilities/queen/queen_powers.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/carbon/xenomorph/abilities/queen/queen_powers.dm
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't define these procs on /datum/action/xeno_action, these should be on /ManageHive rather
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll test this later. But some simple changes to naming of procs.
code/modules/mob/living/carbon/xenomorph/abilities/queen/queen_powers.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/carbon/xenomorph/abilities/queen/queen_powers.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/carbon/xenomorph/abilities/queen/queen_powers.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/carbon/xenomorph/abilities/queen/queen_abilities.dm
Show resolved
Hide resolved
…_powers.dm Co-authored-by: Birdtalon <[email protected]>
…_powers.dm Co-authored-by: Birdtalon <[email protected]>
added give evo ponits too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly fine and works fine. Would be nice if you could remove the now unused original xeno_actions
though.
code/modules/mob/living/carbon/xenomorph/abilities/queen/queen_powers.dm
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retain the plasma checks and costs to perform the abilities that had a cost. You also may want the plasma cost in the dropdown list like it was when I reviewed it before if you ended up removing that.
About the pull request
Puts the banish/readmit/devolve into one category of "manage hive"
Explain why it's good for the game
Queen ui is cluttered as hell and disheartening for new players this aims to clear it up and put it into managable parts, this is the part one of it.
Testing Photographs and Procedure
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑
qol: Moves "Banish, Re-admit and De-evolving" queen abilities into one list, making the queen ui less clutterier
/:cl: