Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncluttering Queen UI P1 #5350

Merged
merged 28 commits into from
Jan 12, 2024
Merged

Uncluttering Queen UI P1 #5350

merged 28 commits into from
Jan 12, 2024

Conversation

Red-byte3D
Copy link
Contributor

@Red-byte3D Red-byte3D commented Dec 31, 2023

About the pull request

Puts the banish/readmit/devolve into one category of "manage hive"

Explain why it's good for the game

Queen ui is cluttered as hell and disheartening for new players this aims to clear it up and put it into managable parts, this is the part one of it.

Testing Photographs and Procedure

image

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
qol: Moves "Banish, Re-admit and De-evolving" queen abilities into one list, making the queen ui less clutterier
/:cl:

@github-actions github-actions bot added the Quality of Life Make the game harder to play label Dec 31, 2023
@Red-byte3D
Copy link
Contributor Author

image
this was giving me an error and i couldnt get it to work so i removed it completely, if somebody could tell me why it wouldnt work / suggest the fix it would be awesome do not merge untill i do that please

@Drulikar Drulikar marked this pull request as draft December 31, 2023 05:38
Copy link
Member

@fira fira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't define these procs on /datum/action/xeno_action, these should be on /ManageHive rather

@Red-byte3D Red-byte3D marked this pull request as ready for review January 1, 2024 17:28
Copy link
Contributor

@Birdtalon Birdtalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll test this later. But some simple changes to naming of procs.

@Red-byte3D
Copy link
Contributor Author

added give evo ponits too

Copy link
Contributor

@Birdtalon Birdtalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly fine and works fine. Would be nice if you could remove the now unused original xeno_actions though.

Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retain the plasma checks and costs to perform the abilities that had a cost. You also may want the plasma cost in the dropdown list like it was when I reviewed it before if you ended up removing that.

@Drulikar Drulikar marked this pull request as draft January 4, 2024 01:00
@Red-byte3D Red-byte3D marked this pull request as ready for review January 4, 2024 17:38
@Birdtalon Birdtalon marked this pull request as draft January 5, 2024 23:05
@Red-byte3D Red-byte3D marked this pull request as ready for review January 11, 2024 17:34
@Birdtalon Birdtalon added this pull request to the merge queue Jan 12, 2024
Merged via the queue into cmss13-devs:master with commit 6129eae Jan 12, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Jan 12, 2024
@Red-byte3D Red-byte3D deleted the uistuff branch January 18, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quality of Life Make the game harder to play
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants