Fixes xeno ERT distress beacon announcements #5355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fira
reviewed
Jan 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Fixes #5354 by flipping the result of the "Would you like to broadcast the beacon launch?" prompt.
Basically the prompt was setting a variable as if
TRUE== "Yes a broadcast should be launched", when it was actuallyTRUE== "No a broadcast shouldn't be launched".(The parameters on the
activate()proc are pretty weird with one being positive and one negative, but I figured I'd just do the fix here rather than trying to refactor anything.)Explain why it's good for the game
Less MOOC announcements needed about ""bugs"" :P.
Testing Photographs and Procedure
Screenshots & Videos
Before:
dreamseeker_oQFm07drq6.mp4
After:
dreamseeker_DTZj8oMfAR.mp4
Changelog
🆑
fix: Fixed custom xeno ERTs sending a distress beacon announcement when it shouldn't.
/:cl: