Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character name max length increase by 2. #5358

Merged
merged 1 commit into from
Jan 13, 2024

Conversation

blackdragonTOW
Copy link
Contributor

@blackdragonTOW blackdragonTOW commented Jan 1, 2024

About the pull request

Bumping the max name length by two. I've seen a few people who drop the quotations on their nickname to save characters to fit the name they want. This would help allow them to have quotations on their nick again.

Explain why it's good for the game

Letting people have the names they want without having to gimmick the quotation character count.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
qol: increased name character limit by two.
/:cl:

@github-actions github-actions bot added the Quality of Life Make the game harder to play label Jan 1, 2024
@fira
Copy link
Member

fira commented Jan 1, 2024

I don't know, it's bit of an endless chase, there's no reason adding 2 more will stop people from doing that with longer names

@blackdragonTOW
Copy link
Contributor Author

I don't know, it's bit of an endless chase, there's no reason adding 2 more will stop people from doing that with longer names

100% there's genuinely nothing stopping that from happening, and could totally be a "just one more lane bro" type fix but I keep feeling really sad when I see un-quoted nicknames due to character limits.

@realforest2001
Copy link
Member

realforest2001 commented Jan 2, 2024

I, and I think a few others, would like to see the character name field split into three, for forename, nickname and surname. That would allow automatic quotation marks to be included too. Problem with that is balancing lengths becomes harder, without forcing it to be checked to a max limit after assembly. Splitting the fields is probably preferable to arbitrarily adding two characters to the limit though.
Edit: I made a rudimentary start to this a while ago, branch is here if you wanted to attempt it. https://github.com/realforest2001/forest-cm13/tree/forest/namechange

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jan 11, 2024
@Birdtalon
Copy link
Contributor

So I'm going to merge this for this reason and I get that would be frustrating for someone's name not to be able to fit. But ideally what Forest suggests above is the more maintainable outcome in the long term.

I don't know, it's bit of an endless chase, there's no reason adding 2 more will stop people from doing that with longer names

100% there's genuinely nothing stopping that from happening, and could totally be a "just one more lane bro" type fix but I keep feeling really sad when I see un-quoted nicknames due to character limits.

@Birdtalon Birdtalon added this pull request to the merge queue Jan 13, 2024
Merged via the queue into cmss13-devs:master with commit 8a44ffd Jan 13, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quality of Life Make the game harder to play Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants