-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Character name max length increase by 2. #5358
Conversation
I don't know, it's bit of an endless chase, there's no reason adding 2 more will stop people from doing that with longer names |
100% there's genuinely nothing stopping that from happening, and could totally be a "just one more lane bro" type fix but I keep feeling really sad when I see un-quoted nicknames due to character limits. |
I, and I think a few others, would like to see the character name field split into three, for forename, nickname and surname. That would allow automatic quotation marks to be included too. Problem with that is balancing lengths becomes harder, without forcing it to be checked to a max limit after assembly. Splitting the fields is probably preferable to arbitrarily adding two characters to the limit though. |
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
So I'm going to merge this for this reason and I get that would be frustrating for someone's name not to be able to fit. But ideally what Forest suggests above is the more maintainable outcome in the long term.
|
About the pull request
Bumping the max name length by two. I've seen a few people who drop the quotations on their nickname to save characters to fit the name they want. This would help allow them to have quotations on their nick again.
Explain why it's good for the game
Letting people have the names they want without having to gimmick the quotation character count.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑
qol: increased name character limit by two.
/:cl: