refactor part1 change define in coulours.dm from COULOUR to COLOR #5361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 1, 2024 19:03
add CL_ in front of all the define in it for short to COLOUR so they don't mess thing up with conflicts
or should i change _math here let's a maintainer decide...
realforest2001
requested changes
Jan 2, 2024
so i can safely move every color define into colours.dm file? |
added 2 commits
January 2, 2024 15:25
remove the CL_ stupid thing integretated _math.dm colors define deleted duplicates define... lIGHT COLOR WHITE WAS JUST WHITE... duplicate for no reason...
AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
realforest2001
approved these changes
Jan 2, 2024
realforest2001
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
So the idea is to standartize and remove as much as possible the use of colour.
in this first PR i wanted to start with define using colour in them.
i also stole define in _math.dm because they add a bunch of define that would have been in conflict. and i didn't really understand why some color where define there...
can understand for blood and pipe but why math would need colors defines??
Explain why it's good for the game
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
refactor: for the file coulours.dm and other files change define in it from COULOUR to COLOR
/:cl: